fix: add checkpoints at task start, attempt_completion, and mode switch #8460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add checkpoint creation at task start to allow reverting to the beginning - Add checkpoint creation when attempt_completion is called to mark task completion - Add checkpoint creation before mode switches to preserve state before mode change - All checkpoints use suppressMessage flag to keep timeline clean Fixes #8458
dosubot
bot
added
size:S
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| // Create a checkpoint at task start to allow reverting to the beginning | ||
| // Use allowEmpty=true to ensure checkpoint is created even with no file changes | ||
| // Suppress the checkpoint_saved chat row to keep the timeline clean | ||
| await this.checkpointSave(true, true) |
Contributor
Author
There was a problem hiding this comment.
P2 — Avoid blocking the task loop: checkpointSave() is designed to run in the background; awaiting here delays the first API call. Fire-and-forget to keep startup responsive.
Suggested change
| await this.checkpointSave(true, true) | |
| void this.checkpointSave(true, true) |
| // Create a checkpoint before switching modes | ||
| // Use allowEmpty=true to ensure checkpoint is created even with no file changes | ||
| // Suppress the checkpoint_saved chat row to keep the timeline clean | ||
| await cline.checkpointSave(true, true) |
Contributor
Author
There was a problem hiding this comment.
P2 — UX latency: awaiting checkpoint here blocks the mode switch on git I/O. Consider non-blocking; the checkpoint will still be recorded, and the mode switch remains snappy.
Suggested change
| await cline.checkpointSave(true, true) | |
| void cline.checkpointSave(true, true) |
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses Issue #8458 by adding checkpoints at three critical points in the task lifecycle to enable easy reverting of changes.
Changes
attempt_completionis called to mark the task completion stateAll checkpoints use:
allowEmpty=trueto ensure checkpoint creation even without file changessuppressMessage=trueto keep the timeline clean and avoid UI clutterTesting
Review Confidence
Code review confidence: 85% (HIGH)
Future Improvements
Consider adding specific unit tests for checkpoint creation at these trigger points to ensure the behavior is maintained.
Fixes #8458
Important
Add checkpoints at task start, attempt completion, and mode switch to enable state reverting, with options to ensure creation and suppress UI messages.
Task.tsto revert to initial state.attemptCompletionTool.tswhenattempt_completionis called to mark task completion.switchModeTool.tsbefore mode switch to preserve state.allowEmpty=trueto ensure creation without file changes.suppressMessage=trueto avoid UI clutter.This description was created by
for c9ea9fc. You can customize this summary. It will automatically update as commits are pushed.